Skip to content

Conversation

@jmacryl
Copy link
Collaborator

@jmacryl jmacryl commented Nov 28, 2025

we were using delete_by_query with a match_all query to delete docs. This can be very ineffiicient in large indices. Instead is it much faster to delete the index and create it again

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Nov 28, 2025
@jmacryl jmacryl added the wip Work in progress, don't review yet label Nov 28, 2025
@datahub-cyborg datahub-cyborg bot added the pending-submitter-response Issue/request has been reviewed but requires a response from the submitter label Nov 28, 2025
@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Nov 28, 2025

✅ Meticulous spotted 0 visual differences across 992 screens tested: view results.

Meticulous evaluated ~8 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit ada6fcd. This comment will update as new commits are pushed.

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 65.60510% with 54 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...elasticsearch/indexbuilder/IndexDeletionUtils.java 62.50% 16 Missing and 5 partials ⚠️
...tadata/search/elasticsearch/update/ESWriteDAO.java 53.12% 12 Missing and 3 partials ⚠️
...rch/elasticsearch/indexbuilder/ESIndexBuilder.java 75.86% 5 Missing and 2 partials ⚠️
...ata/search/elasticsearch/ElasticSearchService.java 66.66% 3 Missing and 2 partials ⚠️
...adata/graph/elastic/ElasticSearchGraphService.java 70.00% 3 Missing ⚠️
...emmetadata/ElasticSearchSystemMetadataService.java 70.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (65.60%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Dec 1, 2025
@codecov
Copy link

codecov bot commented Dec 1, 2025

Bundle Report

Bundle size has no change ✅

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 3, 2025
@jmacryl jmacryl removed the wip Work in progress, don't review yet label Dec 3, 2025
@jmacryl jmacryl enabled auto-merge (squash) December 3, 2025 21:04
@jmacryl jmacryl disabled auto-merge December 3, 2025 21:04
@jmacryl jmacryl merged commit 599585b into master Dec 4, 2025
67 of 70 checks passed
@jmacryl jmacryl deleted the PFP-2064/esclear-is-extremely-inefficient branch December 4, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops PR or Issue related to DataHub backend & deployment pending-submitter-merge product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants